New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox cuts off right hand side by 1px #16
Comments
I've seen the same thing in Chrome in all the notebooks. This just started happening since the release of IPython 3.0.0 (I think). I haven't had a chance to look into it, but will now. |
The issue itself is quite simple, but it's easy to get confused amidst all the divs and CSS rules. A notebook is a collection of Each
This is the reason why the bug is Firefox-only. rlabbe, you say you've seen this elsewhere, but if this is true, it's probably another bug. Anyway, to fix the issue, you can either:
I can send a pull request if you wish. Thanks! |
I've made this change and it works. Thank you for your detailed description; I know about nothing about CSS. |
The CSS was causing the text bounding box to slightly overlap the text. A kind person explained the problem by posting to issue 16. However, his change didn't work. I removed the width field and for some reason all the headings centered themselves. I tried changing their alignment and that didn't work. I comprimised by changing 750 to 540 and that worked. I also slightly changed the font size. It was almost comically large.
Hmm, removing the width made all the heading center themselves. No idea why, or inclination to debug. I've reduced the 750 to 740 and it seems to be working. Just pushed to github. I'll reopen and try to get it right if anyone reports further problems |
Fix issue #16 properly without centered headers
The CSS was causing the text bounding box to slightly overlap the text. A kind person explained the problem by posting to issue 16. However, his change didn't work. I removed the width field and for some reason all the headings centered themselves. I tried changing their alignment and that didn't work. I comprimised by changing 750 to 540 and that worked. I also slightly changed the font size. It was almost comically large.
Fix issue #16 properly without centered headers
I am noticing that in Firefox Ubuntu the div.inner_cell is a few pixels too short, cutting off the end of the row of words and is visually distracting. I notice that other notebooks (from other books) don't have this issue, even though they seem to share the same .css files! But, your font is different than the linked example, so something must be different when you compile it. I can't tell from a first glance of the HTML what is different though.
Looks like a great book otherwise. Gotta tear into it :)
The text was updated successfully, but these errors were encountered: