Make verbose controllable by an option

[maelle]

cc @Athanasiamo -- does it sound like a good idea?

[drmowinckels]

yes! Im my growing PR for pro #92 there is a commit for it

[maelle]

in your PR it is an argument, not an option yet or am I missing something?

I mean that the default value of the argument would be something with getOption("meetupr.verbose")

[drmowinckels]

ah right, sorry I misunderstood. I'm not so used to working with options rather than arguments, so I'm not sure what would be the best, tbh. I'll let you decide.

[maelle]

or, we could make FALSE the default, or make it TRUE by default when the session is interactive. 🤔

[drmowinckels]

what I like with arguments is that is more straight forward for the user how to silence it if they want, options can be a little less accessible.

[maelle]

I'd still have both, since the argument would read the option, you could still use the argument.

[drmowinckels]

ok, that sounds like a nice idea

[maelle]

I'll wait until your PR is merged since it introduces the verbose argument.

I think its default value should be verbose = getOption("meetupr.verbose", rlang::is_interactive())

• this way one can still use the argument
• one can toggle the value via a project/user level Rprofile
• the default is still TRUE in interactive session.
• rlang::is_interactive() can be mocked in tests so easier to test we supress messages when we should.