Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to move "posh" from praise #96

Open
Lextuga007 opened this issue Jul 22, 2021 · 2 comments
Open

Request to move "posh" from praise #96

Lextuga007 opened this issue Jul 22, 2021 · 2 comments

Comments

@Lextuga007
Copy link
Contributor

Would it be possible to remove the word "posh" from the praise file https://github.com/rladies/praise/blob/ab66fe2b6080f0a2d55c4b3c395529a8271a4034/R/adjective.R as this isn't necessarily praise in British English? I checked this on Twitter as a poll as I wasn't sure if it was just me but it got quite a few votes saying no, it isn't a compliment. Although it can be used as praise as in, "don't you look posh!" it's never used in the constructed praise of "you are posh!".

Thanks for a great package - we are using this in our internal package and it's lovely to see who gets the next random praise (which is where I saw this phrase)!

@gaborcsardi
Copy link
Collaborator

Do you want to submit a PR? Thanks!

@Lextuga007
Copy link
Contributor Author

I'd love to 👍🏻 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants