Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular expression #60

Closed
austinhuang0131 opened this issue Jan 22, 2022 · 2 comments
Closed

Regular expression #60

austinhuang0131 opened this issue Jan 22, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@austinhuang0131
Copy link

Would it be possible for the filter to support searching by regular expression?

@rladstaetter rladstaetter added this to the 22.2.0 milestone Jan 22, 2022
@rladstaetter
Copy link
Owner

of course. this is perfectly possible.

the reason it is not already implemented is that i wanted to keep the app very approachable and don't want to overload the application with features.

i personally never use 'advanced' search, i always end up using simple text searches. nevertheless, i would propose there are - one day - two modes of LogoRRR, one 'basic' view and then a more 'sophisticated' view which would contain search via regex, too. the next few milestones i'm trying to exploit time information from log lines and will concentrate on visualisation thereof (like for example #12 or #43 ...). But since I try to prioritize user requests i'll include this in milestone 22.2.0.

@rladstaetter rladstaetter added the enhancement New feature or request label May 8, 2022
@rladstaetter rladstaetter self-assigned this May 8, 2022
rladstaetter added a commit that referenced this issue Aug 6, 2022
#60: adds regular expression search functionality
@rladstaetter
Copy link
Owner

image

Implemented regular expression search, with following features:

  • You can switch between normal text search and regular expression search via a new button (see screenshot).
  • Regular expression search can be activated via a keyboard shortcut (CTRL-R on windows, CMD-R on mac).
  • Every regex will be matched against a single line

Known limitations are:

  • no highlighting of matches (unlike simple text search where hits are highlighted)
  • between program invocations regular expression searches will be converted to simple text searches and thus won't work anymore.

But for Release 22.2.0 I'll go with this implementation and close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants