Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom Head hook to recipe editor template #5

Closed
wants to merge 1 commit into from
Closed

add custom Head hook to recipe editor template #5

wants to merge 1 commit into from

Conversation

newash
Copy link

@newash newash commented Mar 13, 2016

Hi Gezim,

I wasn't expecting a templating system for the editor page, so this is the best I could come up with without being specific about my intended use of the hook.

Also I fixed the HTML section of the image: it was DIV inside P that is not allowed (no block element is allowed inside P) but funnily SPAN with "inline-block" is ok according to the browsers.

Also there was a bug of having two elements with ID "recipe_image" (P and INPUT), but luckily it didn't cause issue with the jQuery script.

What do you think?

@newash
Copy link
Author

newash commented Apr 28, 2016

Bump!
Have you had the chance to check my pull request?

@newash
Copy link
Author

newash commented May 8, 2016

Bump 2.
I'd really love to switch to your plugin, but these changes would be a must for that. Could you review it, please?

Thanks!!

@hgezim
Copy link
Collaborator

hgezim commented Jun 14, 2016

I'm so sorry haven't gotten back. I kept seeing your request and figured you'd moved on or something (hadn't seen your follow up comments, sorry).

Honestly this is hard to say but since you're the only user with this requirement it's hard for me to justify having to maintain this code into the future.

I apologize I dragged my feet on this.

@hgezim hgezim closed this Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants