Fix alignment issue in recipe creating window | Add alt text of image to image alt attr in recipe #59

hgezim · 2017-01-09T14:17:47Z

Fixed issue with alignment in create recipe window
Added alt text to images.

hgezim · 2017-01-12T05:04:19Z

Author field is kind of messed up:

hgezim · 2017-01-12T05:11:55Z

You can add an image in ingredients and instructions like this:

ingredient 1
ingredient 2
%https://static.thespicehouse.com/images/image/30/large_red-hot-chili.jpg

Print preview resizing isn't happening in this case:

hgezim

A couple fixes. Also looks like there's a conflict.

hgezim · 2017-01-09T19:40:05Z

.gitignore

@@ -6,3 +6,4 @@ src/vendor-dev/
 plugins/
 node_modules/
 build/
+/nbproject/private/


Add nbproject to .gitignore so this won't be added.

Okay i got it

hgezim · 2017-01-09T19:41:08Z

src/styles/zlrecipe-dlog.css

+#amd-zlrecipe-uploader #recipe-title p.error-message { margin-left: 120px; }
+
+/*-----[sahil fixes]-----*/


These comments aren't necessary.

hgezim · 2017-01-09T19:41:40Z

src/views/create-update-recipe.twig

@@ -80,6 +80,7 @@
            // Show it
            // Set $image src to url
            // scale image
+            //console.log(imageData.alt);


Clean this up.

Okay i will

hgezim · 2017-01-12T05:00:38Z

src/styles/zlrecipe-dlog.css

+    width:90%;
+}
+/*-----[/sahil fixes]-----*/


Remove comment plz

Okay i will

hgezim · 2017-01-12T05:00:56Z

src/styles/zlrecipe-print.css

+    height:auto;
+    display:block;
+}
+/*------[/sahil fixes]----------*/


Remote comment

hgezim · 2017-01-12T05:01:01Z

src/styles/zlrecipe-print.css



 /* END PRINT FORMATTING */
+/*------[sahil fixes]----------*/


Remove comment

hgezim · 2017-01-12T05:01:29Z

src/styles/zlrecipe-print.css



 /* END PRINT FORMATTING */
+/*------[sahil fixes]----------*/
+#zlrecipe-print-container img.photo{
+    max-width:100% !important;


Shouldn't resort to using !important for no good reason.

hgezim commented Jan 12, 2017

View reviewed changes

hgezim force-pushed the bugfixes branch from 251dfcf to 43c25a7 Compare January 26, 2017 05:19

Fixed alignment issue in recipe create box, image printing

ae82718

hgezim force-pushed the bugfixes branch from 43c25a7 to ae82718 Compare January 30, 2017 16:00

hgezim merged commit 3c90764 into master Jan 30, 2017

hgezim deleted the bugfixes branch January 30, 2017 16:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix alignment issue in recipe creating window | Add alt text of image to image alt attr in recipe #59

Fix alignment issue in recipe creating window | Add alt text of image to image alt attr in recipe #59

hgezim commented Jan 9, 2017

hgezim commented Jan 12, 2017

hgezim commented Jan 12, 2017

hgezim left a comment

hgezim Jan 9, 2017

sahilbabu Jan 12, 2017

hgezim Jan 9, 2017

hgezim Jan 9, 2017

sahilbabu Jan 12, 2017

hgezim Jan 12, 2017

sahilbabu Jan 12, 2017

hgezim Jan 12, 2017

sahilbabu Jan 12, 2017

hgezim Jan 12, 2017

hgezim Jan 12, 2017

		#amd-zlrecipe-uploader #recipe-title p.error-message { margin-left: 120px; }

		/-----[sahil fixes]-----/

Fix alignment issue in recipe creating window | Add alt text of image to image alt attr in recipe #59

Fix alignment issue in recipe creating window | Add alt text of image to image alt attr in recipe #59

Conversation

hgezim commented Jan 9, 2017

hgezim commented Jan 12, 2017

hgezim commented Jan 12, 2017

hgezim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment