Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set bug? #115

Open
relsqui opened this issue Aug 3, 2013 · 1 comment
Open

Set bug? #115

relsqui opened this issue Aug 3, 2013 · 1 comment
Labels

Comments

@relsqui
Copy link
Collaborator

relsqui commented Aug 3, 2013

set jeans.description = "http://www.youtube.com/watch?v=vwGlhKcEBjY"
I don't know what object you mean by 'jeans.description = "http://www.youtube'

@relsqui
Copy link
Collaborator Author

relsqui commented Sep 12, 2015

The problem, sort of, is in the Set argument regex: https://github.com/rlazarus/MUSS/blob/master/muss/commands/building.py#L153

It's matching greedily until the second dot in the url and treating everything before that as the object name. This doesn't have a clean solution. We could split on the equals sign instead, but then we'd have the same problem with object names that have equals signs in them (or, heaven help us, both). That said, it's the more sensible split anyway -- we're way more likely to want dots in object names (and strings) than equals signs, and the equals is a meaningful division in the way the dot is not. However, it probably needs to be paired with either an escaping mechanism (for when you really need the equals in the object name) or a larger syntax change (stop allowing spaces in object references, or simply require a UID, for example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant