Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

🔧 add makefile #58

Merged
merged 2 commits into from
Oct 31, 2017
Merged

🔧 add makefile #58

merged 2 commits into from
Oct 31, 2017

Conversation

SiegfriedEhret
Copy link
Contributor

@SiegfriedEhret SiegfriedEhret commented Oct 31, 2017

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 866b7e7 on SiegfriedEhret:feature/makefile into 97bd93e on rlespinasse:master.

Copy link
Owner

@rlespinasse rlespinasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also can improve the README with this makefile

Makefile Outdated
help: ## Print this message
@grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-20s\033[0m %s\n", $$1, $$2}'

.PHONY: test
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add bench and test also

@rlespinasse rlespinasse self-assigned this Oct 31, 2017
@SiegfriedEhret
Copy link
Contributor Author

@rlespinasse

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling af3d727 on SiegfriedEhret:feature/makefile into 3e581ac on rlespinasse:master.

Makefile Outdated
help: ## Print this message
@grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-20s\033[0m %s\n", $$1, $$2}'

.PHONY: test bench
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I forgot to ask about help in the PHONY section

@SiegfriedEhret
Copy link
Contributor Author

@rlespinasse 🎁 💖

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e801fe9 on SiegfriedEhret:feature/makefile into 161495f on rlespinasse:master.

Copy link
Owner

@rlespinasse rlespinasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlespinasse rlespinasse merged commit 0dca882 into rlespinasse:master Oct 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants