Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an "engines" property to warn node 0.11/0.12 users #21

Closed

Conversation

hristozov
Copy link

As we know (#15), this package won’t work on node 0.11 and 0.12.

This small pull request adds an appropriate engines property in package.json to warn people which attempt to install it on these versions of node, saving them some googling after a build failure.

For example, on my machine this produces something like:

$ npm install ~/src/node-fann
npm WARN engine fann@0.2.4: wanted: {"node":"<0.11"} (current: {"node":"0.12.2","npm":"2.7.5"})

> fann@0.2.4 install /Users/gh/tmp/node_modules/fann
> node-gyp rebuild

…

This restriction should be removed once the 0.11 support is ready.

@rlidwka
Copy link
Owner

rlidwka commented May 9, 2015

I added support for node versions 0.12.x, 1.x and 2.x in 31a251d. Thanks for the reminder. :)

@rlidwka rlidwka closed this May 9, 2015
@hristozov
Copy link
Author

Thank you very much! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants