Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting a tarball directly without previously requesting the package json fails #29

Closed
JessicaMulein opened this issue Dec 12, 2013 · 4 comments

Comments

@JessicaMulein
Copy link
Contributor

We noticed this because we had multiple sinopias behind a load balancer where NPM would get the toplevel on one instance and request the tgz directly on another. Although your normal use case probably doesn't account for load balancers, I would think it's possible that someone clearing out their sinopia cache will experience clients requesting a tarball without first asking for the package json or otherwise attempt to manually download tarball links.

Ideally it should check if it has the package first and pull from upstream otherwise.

Can you confirm? Would you prefer us to PR fixes, do you want to address it, or would this be a won'tfix/won'tmerge?

@rlidwka
Copy link
Owner

rlidwka commented Dec 12, 2013

Confirmed, it fails.

I'll address it since doing it right is a bit non-trivial.

@JessicaMulein
Copy link
Contributor Author

Many thanks. I'd like to add that we're impressed with your responsiveness and proactiveness in keeping ahead of problems. We spent a day investigating the 404/500 failures and created a fix only to find out you'd already fixed it in master. If there's anything I/we can do to help, please let us know. Thanks for being a great maintainer.

(oops, I keep clicking that close and comment button!)

@rlidwka
Copy link
Owner

rlidwka commented Dec 15, 2013

Fixed, and published as sinopia@0.5.7. Thanks for reporting this.

@JessicaMulein
Copy link
Contributor Author

Many thanks. We'll give it a test with our ELB on monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants