Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail save DDB generator #4

Merged
merged 2 commits into from
Jun 21, 2018
Merged

Fail save DDB generator #4

merged 2 commits into from
Jun 21, 2018

Conversation

phstc
Copy link
Contributor

@phstc phstc commented Jun 21, 2018 •
edited
Loading

DDB generator fails if no key or range is supplied

@phstc
Copy link
Contributor Author

phstc commented Jun 21, 2018

@rlister this is ready for your review 😄

rlister
rlister approved these changes Jun 21, 2018
View reviewed changes
Copy link
Owner

@rlister rlister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rlister rlister merged commit 798a2ae into rlister:master Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlister rlister rlister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phstc @rlister