Handle AWS Cloudformation Throttling More Gracefully #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see frequently errors due to AWS throttling. Increasing the number of retries (the default was set to 3 retries) resolves the problem. The sdk does an exponential backoff, and 3 retries was not sufficient for our needs.
Considerations
This PR only increases the number of retries for cloudformation, but potentially, many of the AWS services may benefit from an increase in the retry limit. Additionally, I didn't see an established way for user configuration of such a constant (though imagine this could be set via the Staxfile. I chose to make it configurable via ENV var, but I can change that if there is a more preferred way. Lastly, I arbitrarily made the retry limit very high (100). The thought here was
ctrl-c
is your friend, but I honestly have no idea what a reasonable retry limit should be.