Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't trigger when crusade is used. #1

Open
gotex007 opened this issue Feb 22, 2023 · 15 comments
Open

Doesn't trigger when crusade is used. #1

gotex007 opened this issue Feb 22, 2023 · 15 comments

Comments

@gotex007
Copy link

This doesn't trigger when a retribution paladin uses crusade.

Also it'd be nice if it didn't trigger on an outlaw rogue's blade flurry since that just happens constantly in packs.

@gotex007
Copy link
Author

It also doesn't seem to trigger when metamorphosis is used?

@rljohn
Copy link
Owner

rljohn commented Feb 22, 2023

I'll take a look at removing Blade Flurry and fixing those missing buffs.

@rljohn
Copy link
Owner

rljohn commented Feb 22, 2023

Next build will have a fix for Crusade and will remove Blade Flurry from autodetection.

For Meta - is it Vengeance or Havoc? And is it the one that you cast or procced from cheat death?

@gotex007
Copy link
Author

Havoc. I first noticed it when timewalking and then forgot about it until LFR last night.

@rljohn
Copy link
Owner

rljohn commented Feb 23, 2023

Cool. I'll check it out.

@gotex007
Copy link
Author

Is there any way you can also have it exclude automatically procced buffs like unbridled ferocity proccing recklessness and retribution aura proccing avenging wrath?

@rljohn
Copy link
Owner

rljohn commented Feb 24, 2023

I suppose I could add protection around shorter than expected durations.

@rljohn
Copy link
Owner

rljohn commented Feb 25, 2023

Please try the new build, 1.16

@gotex007
Copy link
Author

gotex007 commented Feb 26, 2023

Havoc metamorphosis worked but it doesn't seem to create an icon in the addon. It's just empty.

It is also triggering on the eye beam meta proc though which isn't very useful.

@gotex007
Copy link
Author

Also it didn't target someone else in my party when my buddy was dead and running back. It just cast it on me.

@rljohn
Copy link
Owner

rljohn commented Feb 27, 2023

I'll take a second look at the havoc meta bugs. It seemed to be working fine with some guildies in town.

As for the macro, macros cannot detect out of range. It currently executes this:

#showtooltip Power Infusion
/use 13
/cast [@PI_BUDDY,help,nodead] Power Infusion
/stopmacro [@PI_BUDDY,help,nodead]
/targetfriendplayer [nohelp]
/cast [help] Power Infusion
/targetlasttarget [help]
/cast [@player] Power Infusion

If your buddy is alive, it will try to target them still. If your buddy is dead, it will target a random friendly target (/targetfriendplayer) if nobody friendly is targeted. If someone friendly is targeted, it will use that target.

Finally, if you are targeting an enemy player and the game could not target a random friendly target ,it will cast on your self.

If you have any alternatives for the macro I can update the addon to use them.

@gotex007
Copy link
Author

I just would have thought it'd have cast it on one of the 3 remaining people near me but it didn't. It just cast it on me.

@gotex007
Copy link
Author

gotex007 commented Feb 28, 2023

Tested it on a fury warrior and havoc demon hunter in this key. It triggers on both the warrior's unbridled ferocity proccing recklessness as well as the demon hunter's eye beam proccing metamorphosis.

I am using PIBuddy 1.16.

@gotex007
Copy link
Author

gotex007 commented Mar 4, 2023

I just had a balance druid as my PIBuddy in this key and it was triggering on his Primordial Arcanic Pulsar proc.

@gotex007
Copy link
Author

gotex007 commented Apr 1, 2023

Wasn't working properly with a destruction warlock in the key I just ran. Infernal wasn't triggering the sound but it would show that the cooldown was active and stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants