Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about orientation in gather_env #52

Closed
lchenat opened this issue Oct 28, 2016 · 1 comment
Closed

Question about orientation in gather_env #52

lchenat opened this issue Oct 28, 2016 · 1 comment

Comments

@lchenat
Copy link
Contributor

lchenat commented Oct 28, 2016

I am a bit confused about how the orientation is calculated in gather_env.py

On line 289 of gather_env.py:

ori = self.inner_env.model.data.qpos[self.class.ORI_IND]

For example, Ant class has ORI_IND 6, and in ant.xml the first joint is the free 'root' joint, then ori should be the value on k axis, since for free joint qpos should be: (x,y,z,a,i,j,k). But ori seems to be the orientation of the agent from the code. Do I misunderstand something?

@dementrock
Copy link
Member

Hmm I think you are right, and the orientation was not computed correctly. I'm really sorry about this. Would you like to submit a pull request with the corrected orientation?

We have not been doing much experiments with the Ant, since the SwimmerGather was already pretty challenging (I believe the orientation should be correct there). But it will be important to correct this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants