Enable more than one MjViewer instance at a time #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for using more than one MjViewer at a time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a feature and a bug fix which allow an rllab user to open more than one MjViewer window at a time.
Bug fix
MjViewer assumes that, once set during MjViewer.start(), the glfw context never changes. This is not true for multiple windows, which share a global glfw context. Each window needs to switch the glfw context to its own window during rendering.
Feature
Add a kwarg to MjViewer which allows the user to change the window title (useful if you're opening more than one).
Both of these could be solved by upgrading mujoco-py to 1.0+, a project I may take on later. For now, these fixes suffice.