use constant for user id session key

requirements.txt

@@ -18,7 +18,7 @@ poster==0.8.1
 py-bcrypt==0.4
 psycopg2==2.6.2
 pytz==2016.10
-requests==2.12.3
+requests==2.12.4
 static==1.1.1
 Unirest==1.1.7
 wsgiref==0.1.2

teamtemp/responses/__init__.py

@@ -1,23 +1,24 @@
 from teamtemp import utils
 
+USER_ID_KEY = 'userid'
 ADMIN_KEY = 'admin_for_surveys'
 
 
-def get_userid(request, default=None):
-    if 'userid' in request.session:
-        return request.session['userid']
+def get_userid(request):
+    if USER_ID_KEY in request.session:
+        return request.session[USER_ID_KEY]
 
-    return default
+    return None
 
 
 def set_userid(request, value):
-    request.session['userid'] = value
-    return request.session['userid']
+    request.session[USER_ID_KEY] = value
+    return request.session[USER_ID_KEY]
 
 
 def create_userid(request):
-    request.session['userid'] = utils.random_string(32)
-    return request.session['userid']
+    request.session[USER_ID_KEY] = utils.random_string(32)
+    return request.session[USER_ID_KEY]
 
 
 def get_admin_for_surveys(request):
@@ -28,14 +29,14 @@ def get_admin_for_surveys(request):
 
 
 def add_admin_for_survey(request, survey_id):
-    admin_for_list = get_admin_for_surveys(request)
-    admin_for_list.add(survey_id)
+    admin_for_surveys_set = get_admin_for_surveys(request)
+    admin_for_surveys_set.add(survey_id)
 
-    request.session[ADMIN_KEY] = list(admin_for_list)
+    request.session[ADMIN_KEY] = list(admin_for_surveys_set)
 
-    return admin_for_list
+    return admin_for_surveys_set
 
 
 def is_admin_for_survey(request, survey_id):
-    admin_for_list = get_admin_for_surveys(request) or set()
-    return survey_id in admin_for_list
+    admin_for_surveys_set = get_admin_for_surveys(request) or set()
+    return survey_id in admin_for_surveys_set