Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Float options (--zoom) ignored in Wrapper #8

Closed
jprabawa opened this issue Aug 24, 2015 · 1 comment
Closed

Float options (--zoom) ignored in Wrapper #8

jprabawa opened this issue Aug 24, 2015 · 1 comment

Comments

@jprabawa
Copy link

The property type loop doesn't consider the type for zoom (float) so setting it won't have any affect.
rlovtangen added a commit that referenced this issue Oct 11, 2015
@rlovtangen
Include float options (e.g. "zoom") in attribute list. Was ignored d…
6418a19 
…ue to missing case for float in property type loop. Fixes #8.

 Commenting out "tocTextSizeShrink", resulted in error message "--toc-text-size-shrink specified in incorrect location". Wasn't enabled previously anyway.
@rlovtangen
Copy link
Owner

Nice catch! Thanks.

@rlovtangen rlovtangen mentioned this issue Mar 12, 2016
Closed
rlovtangen added a commit that referenced this issue Mar 14, 2016
@rlovtangen
Use Float, not float, for zoom property so that default is null, not …
b56456d 
…0.0.

Primitive value (float) results in '--zoom, 0.0' if client doesn't specify zoom property. This results in empty pdf output and error message:

 ERROR org.grails.plugins.wkhtmltopdf.WkhtmltoxExecutor - QFont::setPixelSize: Pixel size <= 0 (0)
 QFont::setPixelSize: Pixel size <= 0 (0)

 Zoom property was enabled in #8

 Fixes #15
rlovtangen added a commit that referenced this issue Apr 26, 2016
@rlovtangen
Use Float, not float, for zoom property so that default is null, not …
cca55d0 
…0.0.

Primitive value (float) results in '--zoom, 0.0' if client doesn't specify zoom property. This results in empty pdf output and error message:

 ERROR org.grails.plugins.wkhtmltopdf.WkhtmltoxExecutor - QFont::setPixelSize: Pixel size <= 0 (0)
 QFont::setPixelSize: Pixel size <= 0 (0)

 Zoom property was enabled in #8

 Fixes #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rlovtangen @jprabawa