Compare other infos when test env pickling (#2033)

src/garage/envs/env_spec.py

@@ -54,3 +54,16 @@ def observation_space(self, observation_space):
 
         """
         self._output_space = observation_space
+
+    def __eq__(self, other):
+        """See :meth:`object.__eq__`.
+
+        Args:
+            other (EnvSpec): :class:`~EnvSpec` to compare with.
+
+        Returns:
+            bool: Whether these :class:`~EnvSpec` instances are equal.
+
+        """
+        return (self.observation_space == other.observation_space
+                and self.action_space == other.action_space)

tests/garage/tf/envs/test_base.py

@@ -12,7 +12,10 @@ class TestGarageEnv:
     def test_is_pickleable(self):
         env = GarageEnv(env_name='CartPole-v1')
         round_trip = pickle.loads(pickle.dumps(env))
+        assert round_trip.spec == env.spec
         assert round_trip.env.spec.id == env.env.spec.id
+        assert (round_trip.env.spec.max_episode_steps ==
+                env.env.spec.max_episode_steps)
 
     @pytest.mark.nightly
     @pytest.mark.parametrize('spec', list(gym.envs.registry.all()))
@@ -29,6 +32,9 @@ def test_all_gym_envs_pickleable(self, spec):
         if spec._env_name.startswith('Defender'):
             pytest.skip(
                 'Defender-* envs bundled in atari-py 0.2.x don\'t load')
+        if spec.id == 'KellyCoinflipGeneralized-v0':
+            pytest.skip(
+                'KellyCoinflipGeneralized-v0\'s action space is random')
         env = GarageEnv(env_name=spec.id)
         step_env_with_gym_quirks(env,
                                  spec,

tests/helpers.py

@@ -43,7 +43,10 @@ def step_env_with_gym_quirks(env, spec, n=10, render=True,
     if serialize_env:
         # Roundtrip serialization
         round_trip = pickle.loads(pickle.dumps(env))
+        assert round_trip.spec == env.spec
         assert round_trip.env.spec.id == env.env.spec.id
+        assert (round_trip.env.spec.max_episode_steps ==
+                env.env.spec.max_episode_steps)
         env = round_trip
 
     env.reset()
@@ -63,7 +66,10 @@ def step_env_with_gym_quirks(env, spec, n=10, render=True,
     if serialize_env:
         # Roundtrip serialization
         round_trip = pickle.loads(pickle.dumps(env))
+        assert round_trip.spec == env.spec
         assert round_trip.env.spec.id == env.env.spec.id
+        assert (round_trip.env.spec.max_episode_steps ==
+                env.env.spec.max_episode_steps)
 
 
 def convolve(_input, filter_weights, filter_bias, strides, filters,