Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap experiment examples #1155

Merged
merged 2 commits into from Jan 26, 2020
Merged

Wrap experiment examples #1155

merged 2 commits into from Jan 26, 2020

Conversation

krzentner
Copy link
Contributor

Also fix an issue with deadlock on process close

@krzentner krzentner requested a review from a team as a code owner January 26, 2020 06:13
@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #1155 into master will increase coverage by 29.15%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1155       +/-   ##
===========================================
+ Coverage   58.46%   87.62%   +29.15%     
===========================================
  Files         182      182               
  Lines        8632     8639        +7     
  Branches     1102     1102               
===========================================
+ Hits         5047     7570     +2523     
+ Misses       3340      868     -2472     
+ Partials      245      201       -44
Impacted Files Coverage Δ
src/garage/experiment/experiment.py 72.72% <100%> (+51.47%) ⬆️
src/garage/experiment/experiment_wrapper.py 92.52% <100%> (+71.57%) ⬆️
...rc/garage/tf/optimizers/penalty_lbfgs_optimizer.py 88.76% <0%> (+1.12%) ⬆️
src/garage/plotter/plotter.py 30.68% <0%> (+1.13%) ⬆️
src/garage/tf/algos/batch_polopt.py 93.87% <0%> (+2.04%) ⬆️
src/garage/tf/algos/dqn.py 97.84% <0%> (+2.15%) ⬆️
src/garage/tf/policies/base.py 97.05% <0%> (+2.94%) ⬆️
src/garage/sampler/vec_env_executor.py 94.11% <0%> (+2.94%) ⬆️
src/garage/tf/distributions/categorical.py 74.24% <0%> (+3.03%) ⬆️
src/garage/np/algos/batch_polopt.py 96.82% <0%> (+3.17%) ⬆️
... and 110 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 876bf4f...45a46b5. Read the comment docs.

Closing the process with a Tensorboard output added to dowel causes the
process to wait forever, since it ends up waiting on a TensorboardX
thread that has already been closed.
@krzentner krzentner merged commit 36634b9 into master Jan 26, 2020
@krzentner krzentner deleted the wrap_experiment_examples branch January 26, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants