Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Plotter and tf Plotter usage #1267

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Separate Plotter and tf Plotter usage #1267

merged 1 commit into from
Apr 1, 2020

Conversation

zequnyu
Copy link
Member

@zequnyu zequnyu commented Mar 31, 2020

  • LocalRunner uses Plotter
  • LocalTFRunner uses tf.Plotter

@zequnyu zequnyu requested a review from a team as a code owner March 31, 2020 23:02
@ryanjulian ryanjulian requested a review from a team March 31, 2020 23:19
@codecov
Copy link

codecov bot commented Mar 31, 2020 •
edited
Loading

Codecov Report

Merging #1267 into master will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1267      +/-   ##
==========================================
+ Coverage   88.59%   88.69%   +0.10%     
==========================================
  Files         194      194              
  Lines        9621     9627       +6     
  Branches     1225     1226       +1     
==========================================
+ Hits         8524     8539      +15     
+ Misses        873      858      -15     
- Partials      224      230       +6
Impacted Files Coverage Δ
src/garage/experiment/local_runner.py 91.83% <100.00%> (ø)
src/garage/sampler/utils.py 83.01% <100.00%> (ø)
src/garage/tf/experiment/local_tf_runner.py 100.00% <100.00%> (ø)
src/garage/misc/tensor_utils.py 90.29% <0.00%> (-1.95%) ⬇️
src/garage/plotter/plotter.py 43.18% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c84691a...07fed81. Read the comment docs.

@zequnyu zequnyu force-pushed the refactor_plotter branch 2 times, most recently from 941523c to 10a8436 Compare April 1, 2020 00:54
@zequnyu zequnyu requested review from ahtsan and naeioi and removed request for a team April 1, 2020 00:56
@zequnyu
Copy link
Member Author

zequnyu commented Apr 1, 2020

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Apr 1, 2020

Command rebase: success

Branch has been successfully rebased

@mergify mergify bot merged commit 31cb330 into master Apr 1, 2020
@ryanjulian ryanjulian deleted the refactor_plotter branch April 8, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanjulian ryanjulian ryanjulian approved these changes

@ahtsan ahtsan ahtsan approved these changes

@naeioi naeioi Awaiting requested review from naeioi

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zequnyu @ryanjulian @ahtsan