Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #1791 #1847

Merged
merged 1 commit into from Aug 4, 2020
Merged

Backport #1791 #1847

merged 1 commit into from Aug 4, 2020

Conversation

ahtsan
Copy link
Contributor

@ahtsan ahtsan commented Aug 4, 2020

No description provided.

@ahtsan ahtsan requested a review from a team as a code owner August 4, 2020 04:37
@ahtsan ahtsan requested review from krzentner and removed request for a team August 4, 2020 04:37
@mergify mergify bot requested review from a team, haydenshively and AiRuiChen and removed request for a team August 4, 2020 04:38
@ahtsan
Copy link
Contributor Author

ahtsan commented Aug 4, 2020

Close #1831

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #1847 into release-2019.10 will decrease coverage by 0.14%.
The diff coverage is 50.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2019.10    #1847      +/-   ##
===================================================
- Coverage            85.63%   85.48%   -0.15%     
===================================================
  Files                  155      155              
  Lines                 7489     7503      +14     
  Branches               928      928              
===================================================
+ Hits                  6413     6414       +1     
- Misses                 896      907      +11     
- Partials               180      182       +2     
Impacted Files Coverage Δ
...c/garage/tf/policies/discrete_qf_derived_policy.py 81.81% <50.00%> (-14.85%) ⬇️
src/garage/envs/grid_world_env.py 84.12% <0.00%> (-4.77%) ⬇️
src/garage/misc/tensor_utils.py 88.23% <0.00%> (-2.36%) ⬇️
src/garage/experiment/experiment_wrapper.py 84.73% <0.00%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 411f657...4efdb92. Read the comment docs.

@ahtsan ahtsan merged commit 14738ce into release-2019.10 Aug 4, 2020
@ahtsan ahtsan deleted the backport_1791_2019_10 branch August 4, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants