Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove misc.autoargs and usages #573

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Remove misc.autoargs and usages #573

merged 1 commit into from
Mar 7, 2019

Conversation

ryanjulian
Copy link
Member

Fixes #362
See #358

@ryanjulian ryanjulian requested review from naeioi, a user and krzentner March 7, 2019 19:18
@ryanjulian ryanjulian requested a review from a team as a code owner March 7, 2019 19:18
@ryanjulian ryanjulian mentioned this pull request Mar 7, 2019
@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #573 into master will increase coverage by 0.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
+ Coverage   58.31%   58.79%   +0.47%     
==========================================
  Files         135      134       -1     
  Lines        9160     9053     -107     
  Branches     1365     1341      -24     
==========================================
- Hits         5342     5323      -19     
+ Misses       3431     3336      -95     
- Partials      387      394       +7
Impacted Files Coverage Δ
garage/baselines/base.py 66.66% <ø> (-1.52%) ⬇️
garage/tf/policies/categorical_gru_policy.py 80% <0%> (ø) ⬆️
...arage/tf/samplers/off_policy_vectorized_sampler.py 71.79% <0%> (ø) ⬆️
garage/misc/krylov.py 17.94% <0%> (ø) ⬆️
garage/sampler/stateful_pool.py 53.78% <0%> (ø) ⬆️
garage/tf/policies/gaussian_lstm_policy.py 78.83% <0%> (ø) ⬆️
garage/tf/policies/gaussian_gru_policy.py 78.67% <0%> (ø) ⬆️
garage/tf/policies/categorical_lstm_policy.py 79.83% <0%> (ø) ⬆️
.../exploration_strategies/epsilon_greedy_strategy.py 96.29% <0%> (+3.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b6e28...008dcb0. Read the comment docs.

Copy link
Contributor

@krzentner krzentner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was the only usage.

Great.

@ryanjulian
Copy link
Member Author

it was previously used a lot in the envs in rlworkgroup/metaworlds

@ryanjulian ryanjulian merged commit 1c299fd into master Mar 7, 2019
@ryanjulian ryanjulian deleted the no-autoargs branch March 7, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Code Audit
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants