Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pytorch #725

Merged
merged 2 commits into from
Jun 18, 2019
Merged

Add pytorch #725

merged 2 commits into from
Jun 18, 2019

Conversation

lywong92
Copy link
Member

No description provided.

@lywong92 lywong92 requested a review from a team as a code owner June 11, 2019 22:06
ryanjulian
ryanjulian reviewed Jun 11, 2019
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@zhanpenghe
Copy link
Member

In order to pass the CI, the first letter of your commit message needs to be capitalized. You can squash them and force-push this branch to resolve it.

@lywong92 lywong92 force-pushed the add_pytorch branch 2 times, most recently from 4b3a036 to e31a6ce Compare June 12, 2019 18:39
@codecov
Copy link

codecov bot commented Jun 12, 2019 •
edited
Loading

Codecov Report

Merging #725 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #725   +/-   ##
=======================================
  Coverage   67.51%   67.51%           
=======================================
  Files         164      164           
  Lines       10173    10173           
  Branches     1328     1328           
=======================================
  Hits         6868     6868           
- Misses       2957     2958    +1     
+ Partials      348      347    -1
Impacted Files Coverage Δ
src/garage/misc/special.py 30.3% <0%> (-3.04%) ⬇️
src/garage/tf/optimizers/first_order_optimizer.py 68.05% <0%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 780c5b7...76a9d5b. Read the comment docs.

zhanpenghe
zhanpenghe reviewed Jun 14, 2019
View reviewed changes
setup.py Outdated Show resolved Hide resolved
zhanpenghe
zhanpenghe approved these changes Jun 14, 2019
View reviewed changes
Copy link
Member

@zhanpenghe zhanpenghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! This looks good to me and please take a look at my minor comments.

@lywong92 lywong92 merged commit 9e9825e into master Jun 18, 2019
@naeioi naeioi added this to Infrastructure in Torch support Jul 26, 2019
@ryanjulian ryanjulian moved this from Infrastructure to Done in Torch support Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanjulian ryanjulian ryanjulian approved these changes

@zhanpenghe zhanpenghe zhanpenghe approved these changes

@yonghyuc yonghyuc yonghyuc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Torch support
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lywong92 @zhanpenghe @ryanjulian @yonghyuc