Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect reset space for object in disassemble #375

Closed
ottofabian opened this issue Jul 7, 2022 · 3 comments
Closed

Incorrect reset space for object in disassemble #375

ottofabian opened this issue Jul 7, 2022 · 3 comments

Comments

@ottofabian
Copy link

The lower bound for the random reset space of the object in disassemble is higher than the upper bound for the first index.
This appears to be an issue for both v1
https://github.com/rlworkgroup/metaworld/blob/18118a28c06893da0f363786696cc792457b062b/metaworld/envs/mujoco/sawyer_xyz/v1/sawyer_disassemble_peg.py#L14-L15
and v2
https://github.com/rlworkgroup/metaworld/blob/18118a28c06893da0f363786696cc792457b062b/metaworld/envs/mujoco/sawyer_xyz/v2/sawyer_disassemble_peg_v2.py#L15-L16

np.random.uniform seems to invert the values in case high > low. However when using explicit seeding with self.np_random, seed = seeding.np_random(seed) self.np_random.uniform raises a ValueError.

@reginald-mclean
Copy link
Collaborator

Hi @ottofabian I cannot replicate this issue (it's possible PR #370 fixed this). As Meta-World ownership has been transferred from the RLWorkGroup to Farama Foundation, I am closing this issue. If there are any questions/issues please join our Discord

@ottofabian
Copy link
Author

Hi @reginald-mclean. The referenced PR might have fixed this bug as it depends how you generate the uniform samples.
Regardless, I would still propose to change the upper and lower bound of the first elements here to avoid issues like this in the future

@reginald-mclean
Copy link
Collaborator

Oh sorry, I misread the original issue. Thanks for pointing out that issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants