add word wrap capability to luma.core.virtual.terminal #78
Conversation
There was a problem hiding this comment.
Does this need altering too: https://github.com/rm-hull/luma.core/blob/master/setup.py#L40 ?
luma/core/virtual.py
Outdated
| self.puts(text) | ||
| self.newline() | ||
| if self.word_wrap: | ||
| text = wrap(text, width=self.width) |
There was a problem hiding this comment.
Does wrap work with ANSI color codes? Would be worth adding a test to check.
There was a problem hiding this comment.
I've added a test but I'm not sure if it's correct, probably not and we need to ignore these ansi color definitions?
There was a problem hiding this comment.
it's def not correct, 'hello world' line is missing. hmm any ideas @rm-hull?
There was a problem hiding this comment.
Hello world is missing because it has scrolled off the top. Clearly the word wrap is counting the ANSI colour code characters rather than interpreting them as zero width.
Wonder whether we need a home grown text wrapper that does take ANSI color codes into account?
Maybe just leave as-is for now.
Interestingly, it has exposed another bug (which was there before your commits) when scrolling when the background colour is not black - see the yellow bar at the bottom.
There was a problem hiding this comment.
I want to look into the issue a bit more before merging, thanks for the feedback.
There was a problem hiding this comment.
There was a problem hiding this comment.
Interestingly, it has exposed another bug (which was there before your commits) when scrolling when the background colour is not black - see the yellow bar at the bottom.
I've opened #79 for that issue.
doc/api-documentation.rst
Outdated
| @@ -37,6 +37,13 @@ API Documentation | |||
| :undoc-members: | |||
| :show-inheritance: | |||
|
|
|||
| :mod:`luma.core.interface.serial` | |||
| """"""""""""""""""""""" | |||
There was a problem hiding this comment.
Think the underline needs to be the same length as the title else doc generation will complain. we should probably add docgen to the toxic was task if possible
luma.core.interfacepackage (Add 4- & 8-bit parallel interfaces #41)luma.core.serialtoluma.core.interface.serialluma.core.serialmodule