ASCII-art emulator #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import string | ||
| import curses | ||
| import collections | ||
| try: |
There was a problem hiding this comment.
this should be avoided, we use py27 and newer.
There was a problem hiding this comment.
Can you be more specific?
Not sure what you're referring to with 'this'
There was a problem hiding this comment.
the import workaround. simply from io import StringIO is enough, isn't it?
There was a problem hiding this comment.
Not exactly sure, but in py2, I think:
- StringIO.StringIO is byte oriented and works with sys.stdout/stderr
- io.StringIO is unicode oriented and doesn't work with sys.stdout/stderr
There was a problem hiding this comment.
A test would show the difference.
luma/emulator/device.py
Outdated
| cleanup method is called. | ||
|
|
||
| Loosely based on https://github.com/ajalt/pyasciigen/blob/master/asciigen.py | ||
| """ |
There was a problem hiding this comment.
add 'since' version nr.
thijstriemstra
approved these changes
Apr 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.