Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin setup to only use luma.core v1.x.y lineage #128

Merged
merged 2 commits into from Oct 24, 2020
Merged

Conversation

rm-hull
Copy link
Owner

@rm-hull rm-hull commented Oct 24, 2020

I want to introduce a breaking change in luma.core to improve performance. This will mean changing how the fullframe and diff-to-previous framebuffers work. I intend releasing that breaking feature as a 2.x.y release.

In order to be able to roll that out without breaking this project, we need to set the install_required to not upgrade luma.core to the 2.x.y release.

Shortly after luma.core 2.x.y is released, this package will be upgraded to use the improved framebuffer.

Copy link
Collaborator

@thijstriemstra thijstriemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add a changelog entry so it can be reviewed and we can use it in all projects?

@rm-hull rm-hull merged commit 6ba6d4f into master Oct 24, 2020
@rm-hull rm-hull deleted the chore/breaking-change branch October 24, 2020 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants