Adds class to back support for ST7789 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually our display is 240x240 pixels, so that's two resolutions this should support. |
|
The namespace changes in this PR have been changed and fixed since opening this PR. |
Gadgetoid
added a commit
to pimoroni/luma.lcd
that referenced
this pull request
Jun 11, 2020
Co-authored-by: Richard Hull <rm_hull@yahoo.co.uk>
rm-hull
added a commit
that referenced
this pull request
Mar 14, 2021
* Documentation * ST7789 support (#92) Co-authored-by: Richard Hull <rm_hull@yahoo.co.uk> * Move from numpy to python for `st7789.display` * Make `flake` happy * Add tests for st7789, change implementation to more in line with other displays * QA remarks * Contrast test * Review remarks addressed * Performance improvement for st7789 Co-authored-by: Richard Hull <rm_hull@yahoo.co.uk> Co-authored-by: Philip Howard <phil@gadgetoid.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're working on an ST7789 breakout garden SPI LCD module, so I've had hardware available for testing.
This draft PR replaces #91 and reflects my approach to implementing this LCD so far, but it has a dependency upon
numpythat I'm not entirely comfortable with.The key issue with this LCD is the 18-bit colour data that needs to be sent- requiring the (hopefully elegant) repacking of 24-bit colour into 18-bits. My familliarity (or lack thereof) with Luma fails me here- is there an established pattern for repacking data that could be used instead?
Among other things it also needs:
For my own future reference, this has been tested and works in the rear SPI port of BG SPI using the command-line:
I can't seem to get it to work on the other SPI port with CE1/BCM7.