Skip to content

Commit

Permalink
Lock down development dependency versions (#355)
Browse files Browse the repository at this point in the history
Because we don't check in `Gemfile.lock`, it's good to lock these down
in our `gemspec` file. This makes sure the build stays consistent if,
say, there's a major breaking release of RSpec, or once we've added
Rubocop to the build we don't want it to randomly fail every time they
add new rules.
  • Loading branch information
mockdeep committed Feb 15, 2019
1 parent e2c9919 commit f747223
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 11 deletions.
6 changes: 0 additions & 6 deletions Gemfile
Expand Up @@ -2,9 +2,3 @@ source 'https://rubygems.org'

# Specify your gem's dependencies in rmagick.gemspec
gemspec

group :development, :test do
gem 'simplecov', require: false
end
# Used by README.textile
# gem "RedCloth"
10 changes: 5 additions & 5 deletions rmagick.gemspec
Expand Up @@ -30,10 +30,10 @@ Gem::Specification.new do |s|
s.required_ruby_version = ">= #{Magick::MIN_RUBY_VERSION}"
s.requirements << "ImageMagick #{Magick::MIN_IM_VERSION} or later"

s.add_development_dependency 'rake-compiler'
s.add_development_dependency 'rspec', '~> 3'
s.add_development_dependency 'rake-compiler', '~> 1.0'
s.add_development_dependency 'rspec', '~> 3.8'
s.add_development_dependency 'rspec_junit_formatter', '~> 0.4.1'
s.add_development_dependency 'rubocop'

s.add_development_dependency 'test-unit', '~> 2'
s.add_development_dependency 'rubocop', '0.64.0'
s.add_development_dependency 'simplecov', '~> 0.16.1'
s.add_development_dependency 'test-unit', '~> 2.5'
end

0 comments on commit f747223

Please sign in to comment.