Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for webp? #60

Closed
bf4 opened this issue Jul 24, 2014 · 8 comments
Closed

Support for webp? #60

bf4 opened this issue Jul 24, 2014 · 8 comments

Comments

@bf4
Copy link
Member

bf4 commented Jul 24, 2014

Issue by jphastings
Thursday Jan 23, 2014 at 10:53 GMT
Originally opened as #97


RMagick doesn't seem to support webp (despite convert on my system working, and calling out to cwebp). Is this implemented or planned?

@sscarduzio
Copy link

+1

@bf4
Copy link
Member Author

bf4 commented Jul 30, 2014

not that I know of.. yet I'd take a PR

@pavoni
Copy link

pavoni commented Oct 21, 2014

+1

@bf4
Copy link
Member Author

bf4 commented Oct 21, 2014

@pavoni PR's appreciated :)

@pavoni
Copy link

pavoni commented Oct 21, 2014

@bf4 I think this is configuration. Working on a Mac I needed ImageMagick 6.8.9-8 (which I couldn't get via homebrew) and then to re-install the rmagic gem.

This then works
image

If it helps anyone, the steps I followed were:-

  1. Uninstalled the hombrew version of ImageMagik to make sure I was using the right version.
  2. Got the later version of ImageMagik from http://cactuslab.com/imagemagick
  3. Fixed up the package path http://stackoverflow.com/a/12434238/2008325

So I suspect no PR needed :-)

@bf4
Copy link
Member Author

bf4 commented Oct 21, 2014

Perhaps this could turn into a PR which tests if we have webp support, else specifies the first version of ImageMagick that has it? Or to document in the README? (I haven't done any research myself apart from reading this issue, but am happy to help guide and support a PR).

@pavoni
Copy link

pavoni commented Oct 21, 2014

The code above will throw an exception if webp support isn't present (it just needs a webp file). Mine is https://www.gstatic.com/webp/gallery/4.sm.webp

Magick::Image::read('./spec/fixtures/uploaders/avatar.webp').first.class

Watson1978 added a commit to Watson1978/rmagick that referenced this issue Mar 7, 2019
Close rmagick#60

If ImageMagick was built with webp library, RMagick should handle `webp` format.
mockdeep pushed a commit that referenced this issue Mar 8, 2019
Close #60

If ImageMagick was built with webp library, RMagick should handle `webp` format.
@mockdeep
Copy link
Member

mockdeep commented Mar 8, 2019

This should work if you're using ImageMagick 6.8 or above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants