Fix install error on Windows MINGW environment and drop Windows MSWIN environment support #1585
+35
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watson1978
force-pushed
the
fix-install-error-windows
branch
12 times, most recently
from
cf434c9
to
d5194d0
Compare
Watson1978
force-pushed
the
fix-install-error-windows
branch
from
bf4789f
to
3c069a9
Compare
Watson1978
changed the title
Watson1978
changed the title
Watson1978
force-pushed
the
fix-install-error-windows
branch
from
1ac6a4e
to
c90a4dc
Compare
|
@mockdeep I am going to drop it as it is difficult to support MSWIN environment. Do you have any concerns? |
|
Seems it would be better to release these changes as v6.0. hmm... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1584
Previously ImageMagick provided
CORE_RL_MagickCore_.libwhere we statically resolve the symbols needed at build time.The latest version no longer provides that file.
This has forced us to modify the build process to resolve symbols using
.dllfiles.In a WINGW environment, dlls can be linked directly.
However, in an MSWIN environment, a lib file is required to solve symbols or modify many source codes.
I think almost all users use RubyInstaller (MINGW environment), so I will drop MSWIN support
This fix will be released as v5.6.0.
After v5.6.0 is released, I let these changes to will be to the main branch as forward port.