add documentation to readme for setting up dev env #164
Conversation
|
|
||
| <pre> | ||
| vagrant ssh | ||
| git clone https://github.com/gemhome/rmagick.git # or your fork |
There was a problem hiding this comment.
I prefer to clone it, edit it, and commit/push changes outside of the ssh session. I only use the ssh session to run tests (and install other rubies, packages etc). If you commit within the session, I don't think it forwards your git config. Try git config --global --list | grep user
There was a problem hiding this comment.
@bf4 Ah, okay. When I ran vagrant ssh it put me in the home directory and when I didn't see the project I assumed I didn't have access to it. Should have read the docs telling that it's in /vagrant.
|
💯 Awesome, thanks for sharing. Now we just need to figure out and document cross-compilation :) Sounds like we can Close #163 (comment) and ref #161 (comment) |
|
@bf4 readme updated. |
|
Looks good to me. We'll need to add more info on building for release, but that can be in another PR |
|
Yeah, I don't think I'm ready to dig into that part just yet. I think know that I've got a passing build I can start working on porting the tests over to rspec. |
|
I'm ok to merge this. |
|
Have at it. I don't have commit rights. |
|
Ok, sent you an invite |
|
Sweet, thanks! |
add documentation to readme for setting up dev env
No description provided.