instructions, source highlighting, edits #1
Conversation
mojavelinux
commented
May 9, 2013
mojavelinux
commented
- add basic instructions for running the application
- enable source highlighting using CodeRay
- add styles from default CodeRay theme
- fix spelling of Markdown
- fix case of AsciiDoc
- use fast erb impl (erubis)
- add basic instructions for running the application - enable source highlighting using CodeRay - add styles from default CodeRay theme - fix spelling of Markdown - fix case of AsciiDoc - use fast erb impl (erubis)
|
Hi Dan, When using erubis i get warns in the log. Any idea why? |
|
Yes, that actually made me aware of a feature we probably need in the Asciidoctor Java integration. C Ruby is single-threaded, so it can be lazy about how it loads libraries. JRuby (and Rubinius) can run in multi-threaded environments, so certain assumptions have to be revisited. One of those assumptions is how libraries are loaded. Since there's no way for the implementation to know what the library might try to do when it's loaded, a warning is issued to make you aware of the fact that things could go wrong if the library is mutating state or other issues of concurrency. In this case, the libraries we're loading lazily (erubis and coderay) aren't modifying mutable state, just making new utilities available to the system, so the warning is superfluous. However, it would still be nice if the Asciidoctor Java integration could preload specified libraries when it boots JRuby, removing the possibility of any problems or warnings. cc: @lordofthejars |
|
Created issue #32 |
instructions, source highlighting, edits
