Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tokio #4

Merged
merged 4 commits into from
Nov 16, 2020
Merged

Support tokio #4

merged 4 commits into from
Nov 16, 2020

Conversation

rmanoka
Copy link
Owner

@rmanoka rmanoka commented Nov 14, 2020 •
edited
Loading

Breakdown

  • factor out spawn functionalities as trait
  • provide implementation using tokio
  • figure out ergonomics of Scope, and the scope_and_* functions
  • update docs
  • make a release

@rmanoka rmanoka mentioned this pull request Nov 14, 2020
Closed
@rmanoka
Support tokio
44a0a81 
WIP to integrate tokio

+ factor out spawning requirements to trait
+ move async-std impls to trait
+ add tokio impls

+ add feature gates
+ port test to work in both frameworks
@rmanoka rmanoka marked this pull request as ready for review November 16, 2020 16:05
@rmanoka rmanoka changed the title WIP: Support tokio Support tokio Nov 16, 2020
@rmanoka
Copy link
Owner Author

rmanoka commented Nov 16, 2020 •
edited
Loading

closes #3
closes #2

@rmanoka rmanoka merged commit b4883d7 into master Nov 16, 2020
@rmanoka rmanoka deleted the feat/tokio branch November 16, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rmanoka