-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Optionally include JS library within generated file #79
Comments
If you run this: import Lang from 'lang.js';
console.log(Lang) What does it print? |
if use import Lang from 'lang.js';
const lang = new Lang();
console.log(lang) it work, but if i use import file message.js from generate |
for now i modified with add option in command let me know if any better solution |
@ardani this looks great! What do you think @vluzrmos @a-komarev @gpopoteur about providing the option for generating the messages without the lib integrated? I think that proposal is pragmatic. |
@rmariuzzo I think this could be useful feature. |
@a-komarev I also share the same feeling on this. However, I would suggest to use another parameter name such as: # Include the lang.js library (by default).
php artisan lang:js --lib
# Do not include the lang.js library.
php artisan lang:js --no-lib What do you think @a-komarev ? |
@rmariuzzo Good one! |
Hey @ardani! Could you create a PR to |
Ok @rmariuzzo |
Hi @rmariuzzo ,
this is great package, very usefull, i try this for my project now.
i have a problem , how to include result generate lang.js to webpack?
i try using this code but error
error message
Uncaught ReferenceError: Lang is not defined
any solution for me?
thanks
The text was updated successfully, but these errors were encountered: