Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ability to configurate list of files to convert to be used by javascript #47

Merged

Conversation

antonkomarev
Copy link
Collaborator

@antonkomarev antonkomarev commented Jul 28, 2016

I've added configuration file for your package.

Right now there could be defined list of language files which should be included in javascript output.

Checks are done via separate method for easier extending functionality in future:

'messages' => [
    'passwords.reset',
    'pagination.next',
    'pagination.previous',
],

2 more cases covered in unit tests, code cleaned up and formatted in PSR-2 (because it's standard since Laravel 5.1).

@rmariuzzo rmariuzzo self-assigned this Jul 28, 2016
@rmariuzzo rmariuzzo added this to the 1.3.0 milestone Jul 28, 2016
@rmariuzzo rmariuzzo merged commit d43122a into rmariuzzo:develop Jul 28, 2016
@rmariuzzo
Copy link
Owner

Thank you very much @a-komarev!

@antonkomarev antonkomarev deleted the feature/exclude-messages-config branch July 28, 2016 19:10
@rmariuzzo
Copy link
Owner

@vluzrmos I'm considering on adding @a-komarev as a contributor. What do you think? I'm basing my decision because on his contributions on this repo, and Lang.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants