Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary code which prevents onBlock to be invoked #153

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gnekoz
Copy link

@gnekoz gnekoz commented Feb 2, 2023

Fix for the issue #152

The deleted line seems to be unnecessary and it will fail when the browser is blocking the popup/tab opening.
This will result in the onBlock callback to never be called

@estubmo
Copy link

estubmo commented Jun 24, 2024

Please merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants