Skip to content
This repository has been archived by the owner on May 31, 2018. It is now read-only.

"Proceed with installation? [Y/n]" wants K or E instead. #436

Closed
Mikaela opened this issue Mar 6, 2016 · 12 comments
Closed

"Proceed with installation? [Y/n]" wants K or E instead. #436

Mikaela opened this issue Mar 6, 2016 · 12 comments

Comments

@Mikaela
Copy link

Mikaela commented Mar 6, 2016

I use Arch in Finnish and when I installed pacaur, I was confused on why it just quit when I answered y or n. Then I tried k and the installation continued and later e so it was aborted.

K is Kyllä (Yes in Finnish) and E is Ei (No in Finnish).

I think pacaur should either accept Y/n as input or ask for what it really wants.

  • pacaur 4.5.4-1 installed from the AUR
  • Arch Linux
@NanoSector
Copy link
Contributor

The same bug happens with Dutch, where it wants J instead of Y (Ja is Yes in Dutch).

@rmarquis
Copy link
Owner

rmarquis commented Mar 6, 2016

This is a translation issue, related to pacman being translated while pacaur doesn't have support for these languages yet. As translations are purely community made, I won't spend time on that issue.

Someone should send a translation (see howto in po directory), the alternative being that I remove translation support completely.

@rmarquis rmarquis added this to the 4.5.x - maintenance milestone Mar 6, 2016
@NanoSector
Copy link
Contributor

I'm currently working on a Dutch translation. :)

@rmarquis
Copy link
Owner

rmarquis commented Mar 6, 2016

Great, I'm looking forward to it!

@rmarquis rmarquis added community and removed wontfix labels Mar 6, 2016
@Mikaela
Copy link
Author

Mikaela commented Mar 6, 2016

Workaround: create alias which sets LANG=en before running pacaur.

In case someone is interested in doing Finnish translation, I started one but I am not comfortable with my translations and the messages are more understandable in English anyway.

@rmarquis rmarquis modified the milestones: 4.6.x - new features, 4.5.x - maintenance Mar 24, 2016
@jurf
Copy link
Contributor

jurf commented Apr 24, 2016

You can just translate the [Y/n] part to get rid of this bug if you're not comfortable translating the rest.

@14mRh4X0r
Copy link
Contributor

14mRh4X0r commented Jan 15, 2017

Would it be an option to check for the existence of a translation before using gettext to get the characters?

@rmarquis
Copy link
Owner

No, because this translated string is passed to pacman during the install/update operations.

@durazell
Copy link

Based on Mikaela's translation here is more complete: https://gist.github.com/durazell/2a218f960b3aaeca933c3112920066ef. I think it would be better to add global y/n support, yaourt supported both y/n and k/e which was more logical (many programs do this).

@rmarquis
Copy link
Owner

Patch welcome.

juergenhoetzel added a commit to juergenhoetzel/pacaur that referenced this issue May 2, 2017
Prevents a mismatch of Y/N in prompt and input check if pacaur doesn't
have a localized "[Y/N]" prompt but pacman has a localized "Y" and
"N" (rmarquis#436).
@juergenhoetzel
Copy link
Contributor

You can just translate the [Y/n] part to get rid of this bug if you're not comfortable translating the rest.

The root cause of this issue is the use of different text domains for the prompt (pacaur) and input-check (pacman), which is wrong IMO. See my Pull Request

rmarquis pushed a commit that referenced this issue May 2, 2017
Prevents a mismatch of Y/N in prompt and input check if pacaur doesn't
have a localized "[Y/N]" prompt but pacman has a localized "Y" and
"N" (#436).
@rmarquis
Copy link
Owner

rmarquis commented May 2, 2017

Fixed in 817d2f9.

@rmarquis rmarquis closed this as completed May 2, 2017
@rmarquis rmarquis modified the milestones: 4.7.x - maintenance, 5.0.x - later May 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants