Skip to content
This repository has been archived by the owner on May 31, 2018. It is now read-only.

New structure #632

Merged
merged 9 commits into from
Jan 29, 2017
Merged

New structure #632

merged 9 commits into from
Jan 29, 2017

Conversation

ismaelgv
Copy link
Contributor

First code splitting. I've organized the functions as it follows:

  • main.sh.in: core functions and top-level stuff.
  • pkgs.sh.in: package related functions.
  • deps.sh.in: dependency related functions.
  • cache.sh.in: cache related functions.
  • info.sh.in: info related functions.
  • utils.sh.in: utility functions like messages, etc.
  • checks.sh.in: group all checkings together.

I've sourced all theses files from the main script. If you want to test it locally you can change functiondir from /usr/share/pacaur to ./libpacaur. Obviously PKGBUILD must be changed to properly install pacaur with these changes.

I need some feedback about this organization.

@rmarquis
Copy link
Owner

rmarquis commented Jan 29, 2017

My only complaint so far is that the .in extension is specific to make (as stated by Alad in #443), which doesn't make sense here. Could you rename these files? Then it's all green for me.

@ismaelgv
Copy link
Contributor Author

Done!

@rmarquis
Copy link
Owner

rmarquis commented Jan 29, 2017

I think you also need to adjust the main pacaur file for new paths :)
Edit: Nvm, it's done.

@rmarquis rmarquis merged commit 80b2041 into rmarquis:pacaur50 Jan 29, 2017
@ismaelgv ismaelgv deleted the new-structure branch January 29, 2017 13:34
@ismaelgv
Copy link
Contributor Author

I was fast... nobody saw it. :P

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants