Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update] Update github action #277

Merged
merged 28 commits into from Jun 1, 2023

Conversation

LuckyPigeon
Copy link
Collaborator

@LuckyPigeon LuckyPigeon commented May 31, 2023

Description

Update GitHub Action to support python3.11.

Fixes #273

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • pytest

Test Configuration:

  • OS version: Windows10
  • Necessary Libraries (optional):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

update ubuntu & python version
update ubuntu & python version
@LuckyPigeon
Copy link
Collaborator Author

pylint check failed due to python3.11.3 issue, check this for detail.

@rmax
Copy link
Owner

rmax commented May 31, 2023

I'm seeing that others opted to disable pylint meanwhile it gets fixed.

Do you think that's a good option here?

I couldn't figure out if warpt has fixed the issue or not :/

@LuckyPigeon LuckyPigeon marked this pull request as ready for review May 31, 2023 09:26
@LuckyPigeon
Copy link
Collaborator Author

LuckyPigeon commented May 31, 2023

wrapt has already fixed the issue, now only use from wrapt import formatargspec instead of from inspect import formatargspec. But seems python team hasn't change the usage.

I'll disable pylint for the meanwhile.

@LuckyPigeon
Copy link
Collaborator Author

And for the pytest failed, seems the new fingerprint implements differently than before, check the official implementation.
So, I will rollback to previous request_fingerprint for the meanwhile, then implements our own request_fingerprint in another PR.

@LuckyPigeon LuckyPigeon enabled auto-merge (squash) May 31, 2023 16:12
@LuckyPigeon LuckyPigeon requested a review from rmax May 31, 2023 16:17
@LuckyPigeon
Copy link
Collaborator Author

LuckyPigeon commented May 31, 2023

@rmax
I think that's about it. Over all, we stopped pylint for now and do the full checking of python3.11 support, now the rests are setup.py, pip and our next release.

Copy link
Owner

@rmax rmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@LuckyPigeon LuckyPigeon merged commit 29dae3f into rmax:master Jun 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a planned support for Python3.11?
2 participants