DNS Plugin for Infomaniak.com

[Sundypha]

Hi @rmbloger.
First of all: Thank you so much for this ACME client.

I added a DNS Plugin for the hoster Infomaniak from Switzerland.

I did use the plugin on two Windows Servers and a Windows Desktop which all worked well.
I tested:

• example.com
• *.example.com
• sub.example.com
• sub2.sub1.example.com

I've got one question. Is there a way to tell the user if something failed? e.g., the zone hasn't been found? Refer to line 69 and line 150 where I could fail gracefully.

Awaiting your review and feedback!

Best
Simon

[Sundypha]

Just figured that in the function Find-InfomaniakZone I query the zone _acme-challenge.example.com which is unnecessary. Going to create a commit shortly.

[rmbolger]

Hi @Sundypha. Thanks for the submission! Everything looks great at first glance. Give me a bit to review and test.

[rmbolger]

Great job. Just fix the one _acme-challenge check removal and this should be good to merge.

[rmbolger]

I've got one question. Is there a way to tell the user if something failed? e.g., the zone hasn't been found? Refer to line 69 and line 150 where I could fail gracefully.

Forgot to answer this. For things like the domain not being found which you can't really recover from, I'll just use throw "my failure message" to send an exception back up to the user so they can decide what to do.

[Sundypha]

You were right. It failed when I had alias abc.example.com since it was only checking the zone example.com instead of the abc zone. Reverted the commit and added throws.

[Sundypha]

Hi @rmbolger,

Did again another round of testing including timed out API calls to check debug and throw messages.
I figured now why my changes weren't persistent. VS Code opened the files at instdev.ps1 folder (\Documents). First time writing any Powershell code.

Should I add another $apiRoot in the Function Find-InfomaniakZone for consistency?

[rmbolger]

There should definitely be a local instance of $apiRoot within the function so you don't run into any unintended scoping issues. But whether you pass that instance as a parameter in the function or just hard code it doesn't really matter to me. The plugins are pretty small and having to find/replace an extra copy of the string if it ever changes is no big deal.

[Sundypha]

I thought so exactly. I wasn't sure if Powershell has some kind of external scoping into functions called since it was working without but it felt awkward.

[rmbolger]

Added one last fix that it looks like you had found originally and fixed in the Remove method but forgot to copy to the Add method.

[Sundypha]

Hang on, I thought about this one. I'll try if the $RecordName can be used for adding the record instead of the short version.

[Sundypha]

Yes, source_idn would work, but target_idn doesn't. The API request must have target.
We could change it to $RecordName, but I want to try with alias', too.
Will report shortly.

[Sundypha]

With alias'ing the source_idn with $RecordName can't be used, so we stick with the $recShort:

Invoke-RestMethod : {"result":"error","error":{"code":"unexpected_error","description":"An unexpected error occurred"}}

Edit: Just to clarify: The source_idn only fails for the POST request.

[rmbolger]

Thanks for the effort, @Sundypha. I'll try to get this out in a release soon.