New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for memleak and curl_close() never being called #200

Merged
merged 1 commit into from Apr 19, 2016

Conversation

Projects
None yet
2 participants
@kwuerl
Contributor

kwuerl commented Jan 13, 2016

Curl spammed the file descriptor list with CLOSE_WAIT connections and the Requests_Transport_cURL Instances where never actually destroyed because of a $this reference in the curl handle.
This resulted in a memleak and failing requests after a few 100 being made.
I fixed this by removing the reference from the file handle again after each request.

@rmccue

This comment has been minimized.

Owner

rmccue commented Jan 31, 2016

Thanks for the PR! Can you please merge master into this branch? (There was an issue with the tests that I just fixed.)

@kwuerl

This comment has been minimized.

Contributor

kwuerl commented Feb 9, 2016

Done

@rmccue rmccue merged commit b998001 into rmccue:master Apr 19, 2016

3 checks passed

Scrutinizer 44 new issues
Details
codecov/project 88.09% remains the same compared to 25ee8f6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmccue

This comment has been minimized.

Owner

rmccue commented Apr 19, 2016

Thanks, and apologies for the wait!

@rmccue rmccue added the Transports label Apr 19, 2016

@rmccue rmccue added this to the 1.7 milestone Apr 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment