-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolved Several Issues (It's not as bad as 2,453 lines suggests) #522
Conversation
This is a big one. Thank you so much for breaking it down like that.
I'm a big fan of how it keeps db logic abstracted to just the right place. EF is so much better than it used to be. I had to use it several jobs ago back in the .net framework era and it was a nightmare. I quite like it these days.
Color me surprised. In my tests I feel like the icons never showed up right for me without a refresh. |
I just tried out the new trash and I dig it. Thank you. One details RE the new downloaded stats: can you please include them in the exports? |
So glad! It's basic, but it doesn't really need to be more than that. (though it would be nice to see cover art).
Sure thing. |
I did a much better job organizing my commits this time, so it may be helpful to review changes on a commit-by-commit basis.
Add folder icon support to MacOS
Added the fileicon script to the MacOsConfigApp (this alone is 733 lines)
I also fixed that background filesystem bug I told you about by not creating that temporary icon file with the GUID name.
Parallelize post-liberation tasks
Not only does this slightly speed up the download completion, but it frees the UI.
Move TrackedQueue to LibationUiBase
This is just some housekeeping. I'm trying to move shared UI code into LibationUiBase where I can, but unfortunately opportunities are slim!
Fixed the Chardonnay Memory Leak #511
Add audiobook Trash Bin
I basically copied Hangovers' deleted tabs into Libation and called the new dialogs "Trash Bin". Trash Bin is accessible from the Settings menu. It offers undelete and permanent deleting.
Solves #433 and #514
Add last download into to database
I took your advise and used
HasConversion
. It's pretty clean.Add Last Download column to grid
Solves #498
Convert queue expand/collapse button text to images
Solves the Expand/Collapse Process Queue symbols issue in #339
Improved custom Folder Icons
It turns out a lot of that stuff you copied from from here isn't necessary. The icon and desktop.ini files don't need to be system files, and you don't need to refresh after changing the folder's attribute. Also, adding
ConfirmFileOp=0
to the ini file prevents the system from warning users that they're about to delete a system folder.I also moved the icon encoder to LibationUiBase.IcoEncoder. It implements
SixLabors.ImageSharp.IImageEncoder
, so you can now callImage.Save(Stream, IcoEncoder)
.