Minor Bug fixes

[Mbucari]

Add support for locating mp3 audiobooks

The "Locate Audiobooks" function will now locate mp3s.

Remove unused response groups

This is just another step in trying to eek out another few milliseconds of performance from the library scan. I went through all response groups and removed the ones that provided unused data.

Add scrolling view to settings window panels (#720)

Chardonnay only. The tabs are placed inside a scroll viewer control so the window can be shrunk to smaller than the tab while still allowing all options to be accessed. I did only the most cursory search for a winforms equivalent but couldn't find one. Let me know if you have any ideas how we could add the same feature to classic.

Create directory before trying to create appsettings.json

Create the "Libation" subdirectory before trying to create appsettings.json. This only has the potential to affect mac and linux because windows should always be able to write to the libation program files directory.

Update AAXClean

There are a few things in here.

• AAXClean now properly writes track numbers to mp3 files split by chapter.
• Set the track number on the converted mp3 when converting to mp3.
• Change how metadata is read from m4b files in the "Locate Audiobooks" process to improve performance.

Fix issue with save button being disabled.

This has been broken for a long time and I keep forgetting to fix it. When selecting "Returning User" in Libation setup on chardonnay, users were unable to save the selected directory.

Update InstallOnMac.md

Add troubleshooting steps for mac users.

Add support for environment variables and unix shortcuts in appsettings.json path

.NET still has room for improvement to become truly cross-platform. IO can't interpret the home path (~/) shortcut, and Environment.ExpandEnvironmentVariables() only works for %MyENV% type environment variables, not unix's $MyENV variables. I added a hack for unix systems that calls the shell to echo the path name, thereby expanding it to it's full path. I only did this for LibationFiles directory in appsettings.json because I don't think it's needed anywhere else.

[rmcrackan]

Let me know if you have any ideas how we could add the same feature to classic.

Winforms panel with scrollbars

.NET still has room for improvement to become truly cross-platform

For sure. Win feels native and the others feel like a chore.

These look good to me. Ready for merge? Or would you like more time?

[Mbucari]

These look good to me. Ready for merge? Or would you like more time?

Give me a chance to add the scroll viewer to winforms.

[rmcrackan]

Sounds good. Just reply here whenever you're ready.

[Mbucari]

@rmcrackan Dunzo. Thankfully TabPage inherits from Panel so I could just enable AutoScroll on each tab.

[rmcrackan]

Huh. I don't think I ever realized it inherited in that way.

Release today? Or do you have other things in the pipeline?

[Mbucari]

Release today? Or do you have other things in the pipeline?

Yeah, please release this. I have some ideas for other open feature request issues, but I'm not quite ready to start working on them in earnest.

[Mbucari]

Holy crap, the unix ExpandEnvironmentVariables issue has been open since 2018!

[rmcrackan]

Released

Holy crap, the dotnet/runtime#25792 has been open since 2018!

Like we said: Win feels native; mac and linux feel hacky.