Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a kernel parameter to create a trusted sandbox #14

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Add a kernel parameter to create a trusted sandbox #14

merged 2 commits into from
Feb 25, 2021

Conversation

mpcjanssen
Copy link

Fixes #13

@rmculpepper
Copy link
Owner

Thanks for the PR! There is one issue, which is that call-with-trusted-sandbox-configuration does not set the parameters listed under "Not set by call/trusted" in the code of call-with-kernel-sandbox-configuration. The most important is sandbox-namespace-specs: without that setting, the picts in the Getting Started example notebook don't render as images.

@mpcjanssen
Copy link
Author

@rmculpepper I have created a separate configuration proc for the trusted scenario. Networking still works and images display correctly again.

@mpcjanssen
Copy link
Author

@rmculpepper anything remaining to have this merged?

@rmculpepper
Copy link
Owner

I think this is good. Thanks!

@rmculpepper rmculpepper merged commit 2f240df into rmculpepper:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally start the kernel with a trusted sandbox
2 participants