Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added light theme for kitty, alacritty and .Xresources #45

Merged
merged 3 commits into from
Aug 26, 2022
Merged

added light theme for kitty, alacritty and .Xresources #45

merged 3 commits into from
Aug 26, 2022

Conversation

kndndrj
Copy link
Contributor

@kndndrj kndndrj commented Aug 26, 2022

Hey,
I found your light theme pretty nice and decided to add it to my terminal. That's why I ported it to all terminals I currently had installed.

I tested all of them briefly, but If you find any improvements, feel free to add them or let me know :).
Hope you don't mind me changing the directory structure of extras.

Also, I couldn't test the theme for iTerm, so I didn't add it.

@rmehri01
Copy link
Owner

Hey, I'm glad you like the light theme! Thanks for the pr, I'll test them out and add iTerm too. And yeah no problem, I think the directory structure is a good change!

Copy link
Owner

@rmehri01 rmehri01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I think the iTerm colors weren't actually changed so I just updated them and made a few changes to the docs. Other than that I think it looks great!

@rmehri01 rmehri01 merged commit 66f3c29 into rmehri01:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants