Skip to content

Commit

Permalink
Changed examples and cran comments
Browse files Browse the repository at this point in the history
Changed examples to be faster, edited cran comments to reflect new
timings
  • Loading branch information
rmendels committed Jan 4, 2017
1 parent 1873d66 commit b235710
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 16 deletions.
4 changes: 2 additions & 2 deletions R/xtracto.R
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
#' xpos <- c(230, 235)
#' ypos <- c(40, 45)
#' tpos <- c('2006-01-15', '2006-01-20')
#' xlen <- 0.1
#' ylen <- 0.1
#' xlen <- 0.05
#' ylen <- 0.05
#' extract <- xtracto(xpos, ypos, tpos, 150, xlen, ylen)
#' \donttest{
#' extract <- xtracto(xpos, ypos,tpos, 150, xlen, ylen, verbose = TRUE)
Expand Down
31 changes: 19 additions & 12 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,22 @@ Possibly mis-spelled words in DESCRIPTION:

Everythng above is correct.

** running examples for arch 'i386' ... [36s] OK
Examples with CPU or elapsed time > 5s
user system elapsed
xtracto 1.53 0.38 10.22
xtracto_3D 1.04 0.06 15.29
xtractogon 0.87 0.04 6.08
xtracto 1.74 0.24 10.88
xtractogon 1.19 0.00 7.16
xtracto_3D 0.69 0.03 8.73
searchData 0.02 0.00 5.96
** running examples for arch 'x64' ... [33s] OK
Examples with CPU or elapsed time > 5s
user system elapsed
xtracto 1.66 0.28 10.87
xtractogon 1.01 0.02 6.88
xtracto_3D 0.64 0.02 7.47
searchData 0.04 0.00 5.43

What this package does is download data from a remote server. I have cut down the examples significantly, but wanted to leave at least one running test. I have gotten the times down to close to 10s. The times will vary based on the speed of the test machine internet and how busy our server is, which is often busy.
What this package does is download data from a remote server. I have cut down the examples significantly from my previous attempt for this version, but wanted to leave at least one running test that reflected what the scripts do. I have gotten the times close to 10s. The times will vary based on the speed of the test machine internet and how busy our server is, which is often busy. The times I get from home are faster than what you get on the CRAN computers.

There were 3 NOTEs from win-builder-devel:

Expand All @@ -35,16 +44,14 @@ Possibly mis-spelled words in DESCRIPTION:

Everythng above is correct.

** running examples for arch 'i386' ... [45s] NOTE
** running examples for arch 'i386' ... [30s] NOTE
Examples with CPU or elapsed time > 10s
user system elapsed
xtracto 3.25 0.18 12.12
xtracto_3D 1.15 0.11 18.31
** running examples for arch 'x64' ... [45s] NOTE
user system elapsed
xtracto 2.87 0.2 10.17
** running examples for arch 'x64' ... [30s] NOTE
Examples with CPU or elapsed time > 10s
user system elapsed
xtracto 3.54 0.31 11.61
xtracto_3D 1.11 0.20 17.27
user system elapsed
xtracto 3.2 0.25 10.98

See comment above about the timings.

Expand Down
4 changes: 2 additions & 2 deletions man/xtracto.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b235710

Please sign in to comment.