Do not allow "." hostname when converting to UNC path

rmisev · Nov 22, 2023 · bb9763c · bb9763c
1 parent 1f95bfb
commit bb9763c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/include/upa/url.h b/include/upa/url.h
@@ -3125,6 +3125,9 @@ inline std::string path_from_file_url(const url& file_url, file_path_format form
     } else {
         // format == file_path_format::windows
         if (is_host) {
+            // UNC path cannot have "." hostname, because "\\.\" means DOS devices namespace
+            if (hostname == ".")
+                throw url_error(validation_errc::file_url_unsupported_host, "UNC path cannot have \".\" hostname");
             // UNC path
             path.append("\\\\");
             path.append(hostname);

diff --git a/include/upa/url_result.h b/include/upa/url_result.h
@@ -81,6 +81,7 @@ enum class validation_errc {
     // path_from_file_url errors
     not_file_url,                   ///< Not a file URL
     file_url_cannot_have_host,      ///< POSIX path cannot have host
+    file_url_unsupported_host,      ///< UNC path cannot have "." hostname
     file_url_invalid_unc,           ///< Invalid UNC path in file URL
     file_url_not_windows_path,      ///< Not a Windows path in file URL
 };

diff --git a/test/test-url.cpp b/test/test-url.cpp
@@ -683,6 +683,8 @@ TEST_CASE("path_from_file_url") {
         CHECK_THROWS_AS(path_from_file_url("file://host/", upa::file_path_format::windows), upa::url_error);
         CHECK_THROWS_AS(path_from_file_url("file:////host/", upa::file_path_format::windows), upa::url_error);
         CHECK_THROWS_AS(path_from_file_url("file://///host/", upa::file_path_format::windows), upa::url_error);
+        // Unsupported "." hostname
+        CHECK_THROWS_AS(path_from_file_url("file://./name", upa::file_path_format::windows), upa::url_error);
     }
     SUBCASE("Native path") {
 #ifdef _WIN32