Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow "." and ".." as UNC share names #34

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Do not allow "." and ".." as UNC share names #34

merged 1 commit into from
Nov 26, 2023

Conversation

rmisev
Copy link
Owner

@rmisev rmisev commented Nov 26, 2023

Because they have a special meaning and are removed by the URL parser.

Because they have a special meaning and are removed by the URL parser.
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5abb4a4) 99.73% compared to head (99c3e20) 99.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files          16       16           
  Lines        2291     2305   +14     
=======================================
+ Hits         2285     2299   +14     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rmisev rmisev merged commit 99c3e20 into main Nov 26, 2023
22 checks passed
@rmisev rmisev deleted the unc-path branch November 26, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant