-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QVM and Quil compiler closing. #12
Comments
Additionally, it would be great to have checks to see if the processes are running. If they are, |
Right now, it kills any previous working processes and restarts the servers. I think I'll add this in stopQVMandQUILC too. Would doing that be okay? |
Yes, that would be great. |
Any updates on this @obliviateandsurrender? |
Really sorry! Had been busy with some other projects. Will do it latest by tomorrow. Just one quick thing I've wanted to ask is if there's any logger implemented in the system? |
No worries on the timing! Just checking in on this. Right now we don't have any logging, no. |
Opened a pull request #16. Inform me of any more modifications, if needed. |
As of now, if one forgets to catch the output of
utils.startQVMandQUILC()
and pass this intoutils.stopQVMandQUILC()
, the processes remain running on their machines. This is undesirable. Ideally, some "safety checks" should be put in place. If not, we must be extremely explicit that this is going to happen, and warn users multiple times.The text was updated successfully, but these errors were encountered: